Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on ADC #659

Merged
merged 1 commit into from
Apr 4, 2018
Merged

Work on ADC #659

merged 1 commit into from
Apr 4, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Update native API to match 1.0.0-preview162
  • Rework ADC code to simplify controller by not exposing the ADC index
  • Update ADC config for NETDUINO3, STM32F4DISCOVERY and STM32F769I-DISCO
  • Update respective readme to document which and what ADC channel and the GPIO mapping are available

Motivation and Context

  • Update API
  • Simplify managed controller by not exposing the ADC index

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets labels Apr 4, 2018
@nfbot
Copy link
Member

nfbot commented Apr 4, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Work on ADC
d7fa9a1 
- Update native API to match 1.0.0-preview162
- Rework ADC code to simplify controller by not exposing the ADC index
- Update ADC config for NETDUINO3, STM32F4DISCOVERY and STM32F769I-DISCO
- Update respective readme to document which and what ADC channel and the GPIO mapping are available

Signed-off-by: josesimoes <[email protected]>
@josesimoes
Copy link
Member Author

@AdrianSoundy could you please check the changes in ESP32?
It should compile but it still requires changes to "group" all ADC channels into a single controller

@josesimoes josesimoes merged commit b3cb841 into nanoframework:develop Apr 4, 2018
@josesimoes josesimoes deleted the work-on-adc branch April 4, 2018 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot