Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on GPIO events #657

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Work on GPIO events #657

merged 1 commit into from
Apr 2, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Fix wrong type in native events preventing GPIO events from firing except on pin 0
  • Fix debounce not working for GPIO events

Motivation and Context

How Has This Been Tested?

  • GPIO+events app from sample repo

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@josesimoes
Work on GPIO events
6e1c0c7 
- Fix wrong type in native events preventing GPIO events from firing except on pin 0
- Fix debounce not working for GPIO events
- Fixes nanoframework#300

Signed-off-by: josesimoes <[email protected]>
@nfbot
Copy link
Member

nfbot commented Apr 2, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Copy link
Member Author

@AdrianSoundy could you please validate this for ESP32.
Also, I got the impression that debounce wasn't implemented on ESP32... Can you confirm?

@josesimoes josesimoes merged commit b1b2445 into nanoframework:develop Apr 2, 2018
josesimoes added a commit that referenced this pull request Apr 2, 2018
@josesimoes
Work on GPIO events (#657)
55f4947
@josesimoes josesimoes deleted the fix-300 branch April 2, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Targets Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPIO events are not firing
2 participants
@josesimoes @nfbot