Added header for ESP32 to define uint8_t etc #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ESP32 it needs the stdint.h header included for the uint8_t etc types. Reverted Configuration_Network back to using these types. Doesn't seem to be a problem for the STM32 builds. with header included.
|
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
pushed a commit
to Eclo/nf-interpreter
that referenced
this pull request
Mar 19, 2018
josesimoes
pushed a commit
to Eclo/nf-interpreter
that referenced
this pull request
Mar 20, 2018
josesimoes
added
Type: bug
Series: ESP32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ESP32 it needs the stdint.h header included for the uint8_t etc types.
Reverted Configuration_Network back to using these types.
Doesn't seem to be a problem for the STM32 builds with header included.
How Has This Been Tested?
Built ESP32 and F746ZG builds without error
Types of changes
Checklist:
Signed-off-by: adriansoundy [email protected]