Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on serial #585

Merged
merged 2 commits into from
Jan 23, 2018
Merged

Work on serial #585

merged 2 commits into from
Jan 23, 2018

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jan 23, 2018 •
edited
Loading

Description

  • Fix wrong check for UART Rx IRQ handler
  • Improve macro to configure UART pins
  • Correct declarations for all targets implementing UART

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Fix wrong check for UART Rx IRQ handler
b39619c 
- The code was missing an extra check if the UART object was expecting anything before setting the event flag

Signed-off-by: José Simões <[email protected]>
@josesimoes
Improve macro to configure UART pins
3a09c5d 
- Now the pins don't have to be on the same GPIO port
- Correct declarations for all targets implementing UART

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: bug Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Jan 23, 2018
@nfbot
Copy link
Member

nfbot commented Jan 23, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 0c1d464 into nanoframework:develop Jan 23, 2018
@josesimoes josesimoes deleted the work-serial branch January 23, 2018 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update defines for UART GPIO configuration
2 participants
@josesimoes @nfbot