Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve serial operations #579

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

josesimoes
Copy link
Member

Description

  • Rework Store and Read to use CLR events for timeout

Motivation and Context

  • The previous implementation using the RTOS waiting functions was blocking the execution engine, thus preventing all other managed threads to run.

How Has This Been Tested?

  • Serial Comm app from samples repo

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

- Rework Store and Read to use CLR events for timeout (using RTOS was blocking the execution engine)
-

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Jan 16, 2018
@nfbot
Copy link
Member

nfbot commented Jan 16, 2018

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 7112210 into nanoframework:develop Jan 16, 2018
@josesimoes josesimoes deleted the improve-serial-operations branch January 16, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants