Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct CRT heap size for nanoBooter #556

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Correct CRT heap size for nanoBooter #556

merged 1 commit into from
Dec 29, 2017

Conversation

josesimoes
Copy link
Member

Description

  • Correct CRT heap size for nanoBooter

Motivation and Context

How Has This Been Tested?

  • Flash nanoBooter in Nucleo F091 and Discovery F769I boards after full flash erase and checked expected ping response from nanoBooter using debugger test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Correct CRT heap size for nanoBooter
b4ee51d 
- Wasn't large enough for Receiver OS thread to run
- Fixes nanoframework/Home#266

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Dec 29, 2017
@nfbot
Copy link
Member

nfbot commented Dec 29, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit be14b24 into nanoframework:develop Dec 29, 2017
@josesimoes josesimoes deleted the fix-266 branch December 29, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wire Protocol isn't working on nanoBooter
2 participants
@josesimoes @nfbot