Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework System.DateTime #553

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Rework System.DateTime #553

merged 1 commit into from
Dec 23, 2017

Conversation

josesimoes
Copy link
Member

Description

  • Extract System.DateTime implementation
  • Add support for new API option for System.DateTime
  • Implement native implementation of set system time for ChibiOS target
  • Clean-up code in HeapBlock
  • Update CMakes accordingly

Motivation and Context

  • Provide separate assembly for System.DateTime

How Has This Been Tested?

  • running RTC.Test app (from samples repo)

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Type: enhancement labels Dec 23, 2017
@nfbot
Copy link
Member

nfbot commented Dec 23, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Rework System.DateTime
2f179b7 
- Extract System.DateTime implementation
- Add support for new API option for System.DateTime
- Implement native implementation of set system time for ChibiOS target
- Clean-up code in HeapBlock
- Update CMakes accordingly
- Update AppVeyor for targets to build with support for System.DateTime

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes merged commit 7bf591d into nanoframework:develop Dec 23, 2017
@josesimoes josesimoes deleted the rework-system-datetime branch December 23, 2017 19:25
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jan 3, 2018
@josesimoes
Revert "Rework System.DateTime (nanoframework#553)"
07d58a3 
This reverts commit 7bf591d.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jan 3, 2018
@josesimoes
Revert "Rework System.DateTime (nanoframework#553)"
c8d0df1 
This reverts commit 7bf591d.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Jan 3, 2018
@josesimoes
Revert "Rework System.DateTime (#553)" (#560)
f5425c8 
This reverts commit 7bf591d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot