Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace duplicate implementations of SafeSprint* #506

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Replace duplicate implementations of SafeSprint* #506

merged 1 commit into from
Sep 15, 2017

Conversation

josesimoes
Copy link
Member

Description

  • remove duplicate implementation in targetHAL_Time
  • replace those with CLR_SafeSprint*
  • implement missing parts of CLR_SafeSprint*

Motivation and Context

  • Reusing code is always a nice improvement.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Replace duplicate implementation of SafeSprint*
8e71870 
- remove duplicate implementation in targetHAL_Time
- replace those with CLR_SafeSprint*
- implement missing parts of CLR_SafeSprint*

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets labels Sep 15, 2017
@nfbot
Copy link
Member

nfbot commented Sep 15, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit b354ca1 into nanoframework:master Sep 15, 2017
@josesimoes josesimoes deleted the rework-printfs branch September 15, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Series: STM32xx Everything related specifically with STM32 targets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot