Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved CLR folder up one level #50

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Moved CLR folder up one level #50

merged 1 commit into from
Jan 11, 2017

Conversation

cw2
Copy link
Contributor

@cw2 cw2 commented Jan 11, 2017

'Native' folder deemed unnecessary, possible layout:

\
+- [bin] -- build output binaries (?)
+- [boards] -- board configuration (?)
+- [build] -- build scripts (?), if there are many of them
+- docs
+- src
   +- CLR
      +- ... 
   +- Framework
      +- ...
+- targets
   +- ...
+- [test]
   +- ... 

@cw2 cw2 requested a review from josesimoes January 11, 2017 13:29
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you are looking into this! 😄
Couple of comments:

  • 'build' folder should be empty. That's were the build outputs, intermediary scripts and other stuff goes when the build is happening or has completed. It's currently on the ignore list for that reason. This folder can/should be wiped out when you are starting a new build of any of the components.

  • short names are not required anymore, disk space is not at a premium nowadays ( 😉 ) 'src' should be 'source' such as any other name throughout the tree

  • not entirely sure about the boards and targets folders... recall the discussion on the Slack channel there should be only one configurable "output object" no matter what is called in the end.

@cw2
Copy link
Contributor Author

cw2 commented Jan 11, 2017

Ad src - that's more personal preference, short name due to historical reasons - back then, there was usually inc and src :) The layout is heavily inspired by dotnet repos, such as https://github.com/dotnet/roslyn (if it works for them ;))

@josesimoes
Copy link
Member

I knew you were going to say that! 😆
I'm from that time too you know, was just trying to place this project in the XXI century were it belongs. 😉

Either name will work, I'm not being anal about this. My preference is always for meaningful names, staying away from short names and abbreviations as much as possible.

@cw2 cw2 merged commit 1edd434 into nanoframework:dev-alpha Jan 11, 2017
@cw2
Copy link
Contributor Author

cw2 commented Jan 11, 2017

Now I owe you a 🍺 / 🍹.

@cw2 cw2 deleted the dev-move-clr branch January 11, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants