Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration for ESP32 UART pattern detection #2153

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Fix code dealing with pattern queue.
  • Fix configuration of pattern detection.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fix code dealing with pattern queue.
- Fix configuration of pattern detection.
@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Nov 15, 2021
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Nov 15, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click josesimoes#14, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…2d95-5108-44e6-a171-933d31fcd42b

Code style fixes for nanoframework/nf-interpreter PR#2153
@josesimoes josesimoes merged commit 635219e into nanoframework:develop Nov 15, 2021
@josesimoes josesimoes deleted the fix-888 branch November 15, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WatchChar is not working in ESP32
2 participants