Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix network interface mapping for ESP-IDF #2145

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Fix network interface mapping for ESP-IDF #2145

merged 1 commit into from
Nov 5, 2021

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 5, 2021 •
edited
Loading

Description

  • Now returning the correct num for the netif struct.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: bug label Nov 5, 2021
@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Nov 5, 2021
@josesimoes josesimoes merged commit c9089a9 into nanoframework:develop Nov 5, 2021
@josesimoes josesimoes deleted the work-880 branch November 5, 2021 18:34
@josesimoes josesimoes mentioned this pull request Nov 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NetworkInterface properties aren't showing the correct data
2 participants
@josesimoes @nfbot