Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SPI implementation for ESP32 #2143

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Remove duplicated code for S.D:Spi and W.D.Spi.
  • Add flag to use INTR_FLAG_IRAM in SPI interrupt code.
  • Improve code that inits SPI bus to use "auto" DMA channel.
  • Fix code style issues.

Motivation and Context

How Has This Been Tested?

  • Tested with several SPI IoT bindings.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Remove duplicated code for S.D:Spi and W.D.Spi.
- Add flag to use INTR_FLAG_IRAM in SPI interrupt code.
- Improve code that inits SPI bus to use "auto" DMA channel.
- Fix code style issues.
@nfbot nfbot added the Type: bug label Nov 1, 2021
@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Nov 1, 2021
@josesimoes josesimoes merged commit 9e62b9b into nanoframework:develop Nov 1, 2021
@josesimoes josesimoes deleted the fix-exp32-spi branch November 1, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants