Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Get Native Memory Info on ESP32 #2140

Merged
merged 4 commits into from
Oct 31, 2021

Conversation

AdrianSoundy
Copy link
Member

Description

Allows the information about amount native memory to queried from Managed code
Using nanoFramework.Hardware.Esp32

Motivation and Context

To allow testing of memory leaks in unit tests

How Has This Been Tested?

Simple test app

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Oct 31, 2021

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click https://github.com/AdrianSoundy/nf-interpreter/pull/40, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

…a-2208-4fad-a292-09a79a436c54' into NativeMemory
@AdrianSoundy AdrianSoundy merged commit 5b22956 into nanoframework:develop Oct 31, 2021
@AdrianSoundy AdrianSoundy deleted the NativeMemory branch October 31, 2021 10:09
@AdrianSoundy
Copy link
Member Author

@josesimoes
I merged a change for this in nanoClr but this seems to be getting a build error on download logo.
Can you have a look whats happening. Maybe only temporary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants