Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix COM port enumeration for ESP32 #2134

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

josesimoes
Copy link
Member

Description

  • String for device selector is now build according to configuration.
  • Allowing UART0 to be available for C# on targets using the embedded USB CDC.

Motivation and Context

  • Fixes issue with wrong COM port enumeration on some ESP32-S2 targets.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added the Series: ESP32S2 Everything related specifically with ESP32S2 series targets label Oct 27, 2021
@josesimoes josesimoes merged commit 02f8a9a into nanoframework:develop Oct 27, 2021
@josesimoes josesimoes deleted the fix-com-ports-esp32 branch October 27, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32S2 Everything related specifically with ESP32S2 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants