Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing orientation for ST7735S and text write native function #2130

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

Ellerbach
Copy link
Member

Description

Fixing orientation for ST7735S and text write native function

Motivation and Context

  • Fixing orientation for ST7735S and text write native function

How Has This Been Tested?

Real devices M5StickC and M5Stack

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Oct 25, 2021

@Ellerbach there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click #2131, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Oct 25, 2021
Automated fixes for code style.
@Ellerbach Ellerbach merged commit 4addfb1 into develop Oct 26, 2021
@Ellerbach Ellerbach deleted the fix-screen-drivers branch October 26, 2021 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants