Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting Dockerfiles for ESP32 IDF4.3 #2101

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

Ellerbach
Copy link
Member

Description

Adjusting Dockerfiles for ESP32 IDF4.3

Motivation and Context

  • Adjusting the Dockerfile.ESP32 to include ESP-IDF
  • Adjusting all installations, path
  • Removing what is not necessary anymore
  • Same for the Dockerfile.All
  • Adjusting the github actions as well to rebuild and push properly in the container registry
  • Adjusting path to the variants json for countainer

How Has This Been Tested?

Local build

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added Type: bug Type: enhancement Type: dependencies Pull requests that update a dependency file(s) or version labels Oct 15, 2021
@Ellerbach Ellerbach merged commit 1b74fe3 into develop Oct 15, 2021
@Ellerbach Ellerbach deleted the adjust-dev-container-esp32-idf43 branch October 15, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Type: bug Type: dependencies Pull requests that update a dependency file(s) or version Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants