Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix implementation of GetCertificateStore and GetDeviceCertificate #2095

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

josesimoes
Copy link
Member

Description

  • A config block is now created from heap in order to return the cert store and the device certificate.

Motivation and Context

  • The recent changes in Rework TLS to use new config manager API #2093 assumed that memory allocation was happening inside there functions. For memory mapped storage, that's not the case, thus, trying to free this memory, causes an hard fault. With this fix, for memory mapped storage, a copy of the bundle/certificate is now performed. The extra memory penalty is not an issue because this happens very briefly when the certs are being parsed to be added to mbedTLS context.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- A config block is now created to return the cert store and the device certificate.

- The recent changes in nanoframework#2093 assumed that memory allocation was happening inside there functions. For memory mapped storage, that's not the case, thus, trying to free this memory, causes an hard fault. With this fix, for memory mapped storage, a copy of the bundle/certificate is now performed. The extra memory penalty is not an issue because this happens very briefly when the certs are being parsed to be added to mbedTLS context.
@nfbot
Copy link
Member

nfbot commented Oct 7, 2021

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries hacktoberfest-accepted labels Oct 7, 2021
@josesimoes josesimoes merged commit e9c7703 into nanoframework:develop Oct 7, 2021
@josesimoes josesimoes deleted the fix-config-manager branch October 7, 2021 13:34
josesimoes added a commit to josesimoes/nf-interpreter that referenced this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants