Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on WP command handlers #2079

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Add reply to the handler on successful execution.
  • Rework return results where needed.
  • Simplification of handling/calling reply processing.
  • Fixed some typos.

Motivation and Context

  • Improvements needed in messaging and debugger handlers.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Add reply to the handler on successful execution.
- Rework return results where needed.
- Simplification of handling/calling reply processing.
- Fixed some typos.
@nfbot
Copy link
Member

nfbot commented Sep 28, 2021

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Sep 28, 2021
@josesimoes josesimoes merged commit 2c0b72c into nanoframework:develop Sep 28, 2021
@josesimoes josesimoes deleted the work-wp-messaging branch September 28, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants