Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assembly load #1995

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Fix assembly load #1995

merged 2 commits into from
Aug 4, 2021

Conversation

MateuszKlatecki
Copy link
Member

Description

Fixed loading of assemblies, in particular:

  • assemblies without static stuff
  • assemblies with static fields but not initialized initialized
  • assemblies with static constructor only (no static fields)

Motivation and Context

How Has This Been Tested?

Tested with code provided in bug report

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

(cherry picked from commit 93840b6e4207e8bd41f738370c84932404bca778)
(cherry picked from commit d71694420d92de908be6fd00c2e8df52689d2a68)
@nfbot nfbot added the Type: bug label Aug 4, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Area: Interpreter Everything related with the interpreter, execution engine and such and removed Area: Common libs Everything related with common libraries labels Aug 4, 2021
@josesimoes josesimoes merged commit 2c15a2c into nanoframework:develop Aug 4, 2021
@MateuszKlatecki MateuszKlatecki deleted the fix/assembly_load branch September 27, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assembly.Load problems
3 participants