Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected some position combinations when R/W to backup memory #1978

Merged
merged 4 commits into from
Jul 7, 2021

Conversation

hackogo
Copy link
Contributor

@hackogo hackogo commented Jul 7, 2021

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dnfadmin
Copy link

dnfadmin commented Jul 7, 2021

CLA assistant check
All CLA requirements met.

@nfbot nfbot added the Type: bug label Jul 7, 2021
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Jul 7, 2021

@hackogo there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click hackogo#1, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

hackogo and others added 2 commits July 7, 2021 22:56
…b34-618e-4090-849e-878399bf5798

Code style fixes for nanoframework/nf-interpreter PR#1978
@josesimoes josesimoes changed the title corrected some position combinations that resulted in wrong read or w… Corrected some position combinations when R/W to backup memory Jul 7, 2021
@josesimoes josesimoes added the Series: STM32xx Everything related specifically with STM32 targets label Jul 7, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@josesimoes josesimoes enabled auto-merge (squash) July 7, 2021 21:30
@josesimoes josesimoes merged commit 4ceda5f into nanoframework:develop Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants