Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.IO.Port declaration #1961

Merged

Conversation

josesimoes
Copy link
Member

Description

  • Fix System.IO.Port declaration.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: bug and removed Type: bug labels Jun 25, 2021
@josesimoes josesimoes merged commit 4f67f17 into nanoframework:develop Jun 25, 2021
@josesimoes josesimoes deleted the fix-serial-io-port-declaration branch June 25, 2021 16:16
@nfbot
Copy link
Member

nfbot commented Jun 25, 2021

@josesimoes there are issues with the code style on the source files.

⚠️Couldn't submit a PR with the fixes against your repo.⚠️

Please merge the changes from https://github.com/nanoframework/nf-interpreter/tree/nfbot/clang-format-fix/001f474b-9b32-4c7c-8438-92d92a94eb43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants