Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in System.IO.Port #1948

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Fix read/write timeout fields.
  • Cleanup code.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Fix read/write timeout fields.
- Cleanup code.
@josesimoes josesimoes added Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets Series: NXP i6 Everything related specifically with NXP targets Series: STM32xx Everything related specifically with STM32 targets and removed Area: Common libs Everything related with common libraries labels Jun 8, 2021
- Fix task to install nbgv.
@josesimoes josesimoes merged commit 159c785 into nanoframework:develop Jun 8, 2021
@josesimoes josesimoes deleted the fixes-serial-port branch June 8, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Series: NXP i6 Everything related specifically with NXP targets Series: STM32xx Everything related specifically with STM32 targets Type: bug Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants