Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SmartConfig #1943

Merged
merged 1 commit into from
Jun 4, 2021
Merged

Conversation

AdrianSoundy
Copy link
Member

Description

This was disabled a long time ago due to bug in IDF where the smartconfig would crash if no AP where found. This problem is fixed in current release v3.3.1

Motivation and Context

Reported on Discord channel

How Has This Been Tested?

Tested using the Esp Touch for Esp8622, ESP32 on Android

With logging enabled

NFPKTV1[00][00][00][00][00][00][00][00][00][00][00][00][00]ÿÿ[00][00][01] [00][00][00][00][00][00]I (423) smartconfig: SC version: V2.8.0
NFPKTV1[00][00][00][00][00][00][00][00][00]	[00][00][00][00][00][00][00][01][00][00][00][00][00][00][00]I (4533) wifi: ic_enable_sniffer
[1B][0;32mI (4533) sc: SC_STATUS_FINDING_CHANNEL[1B][0m
I (19023) smartconfig: TYPE: ESPTOUCH
I (19023) smartconfig: T|PHONE MAC:66:e4:98:97:81:c5
I (19023) smartconfig: T|AP MAC:84:c9:b2:a9:88:16
[1B][0;32mI (19023) sc: SC_STATUS_GETTING_SSID_PSWD[1B][0m
I (21913) smartconfig: T|pswd: <REMOVED>
I (21913) smartconfig: T|ssid: <REMOVED>
I (21913) smartconfig: T|bssid: 84:c9:b2:a9:88:16
I (21913) wifi: ic_disable_sniffer
[1B][0;32mI (21913) sc: SC_STATUS_LINK[1B][0m
[1B][0;32mI (21913) sc: SSID:<REMOVED>[1B][0m
[1B][0;32mI (21913) sc: PASSWORD:<REMOVED>[1B][0m
[1B][0;32mI (21953) wifi: WiFi Connect to <REMOVED> result 0[1B][0m
I (22073) wifi: new:<1,1>, old:<1,0>, ap:<255,255>, sta:<1,1>, prof:1
I (22863) wifi: state: init -> auth (b0)
I (22873) wifi: state: auth -> assoc (0)
I (22883) wifi: state: assoc -> run (10)
I (22993) wifi: connected with <REMOVED>, aid = 6, channel 1, 40U, bssid = 84:c9:b2:a9:88:16
I (22993) wifi: security type: 4, phy: bgn, rssi: -84
I (23003) wifi: pm start, type: 1

I (24323) wifi: AP's beacon interval = 102400 us, DTIM period = 1
[1B][0;32mI (27243) event: sta ip: 192.168.2.122, mask: 255.255.255.0, gw: 192.168.2.1[1B][0m
[1B][0;32mI (30273) sc: SC_STATUS_LINK_OVER[1B][0m
[1B][0;32mI (30273) sc: Phone ip: 192.168.2.123
[1B][0m
[1B][0;32mI (30273) sc: smartconfig over[1B][0m
I (43013) wifi: bcn_timout,ap_probe_send_start
I (229083) wifi: bcn_timout,ap_probe_send_start

Credentials

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This was disabled a long time ago due to bug in IDF where the smartconfig would crash if no AP where found.  This problem is fixed in current release v3.3.1
@nfbot nfbot added the Type: bug label Jun 4, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple? Nicely done.

@josesimoes josesimoes merged commit 8f564cc into nanoframework:develop Jun 4, 2021
@AdrianSoundy AdrianSoundy deleted the smartconfig branch June 5, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants