Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update checksum for STM32 hardware lib #1899

Merged
merged 3 commits into from
May 3, 2021

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented May 2, 2021

Description

The checksum is incorrect with the latest version of the classlib.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented May 2, 2021

Hi @networkfusion,

😞 If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'

@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file(s) or version label May 2, 2021
@nfbot
Copy link
Member

nfbot commented May 2, 2021

@networkfusion there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click #1900, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

Automated fixes for code style.
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@networkfusion this file is missing some formatting and #includes that MDP adds on the stubs from quite sometime. It seems that you don't have installed the latest one (or at least a recent version)...

@josesimoes josesimoes merged commit e7651fd into develop May 3, 2021
@josesimoes josesimoes changed the title Update checksum for STM32 hadware lib Update checksum for STM32 hardware lib May 3, 2021
@josesimoes josesimoes deleted the develop-stm32-hardware-chksum branch May 3, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: dependencies Pull requests that update a dependency file(s) or version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants