Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.Device GpioPin.Read #1898

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Fix System.Device GpioPin.Read #1898

merged 1 commit into from
Apr 29, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Rework native read code to return a proper object.

Motivation and Context

  • Wasn't returning the correct object, just a simple byte value.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Wasn't returning the correct object.
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Apr 29, 2021
@josesimoes josesimoes merged commit 900cae7 into develop Apr 29, 2021
@josesimoes josesimoes deleted the josesimoes-patch-1 branch April 29, 2021 02:25
@josesimoes josesimoes restored the josesimoes-patch-1 branch April 29, 2021 02:32
@josesimoes josesimoes deleted the josesimoes-patch-1 branch April 29, 2021 02:32
josesimoes added a commit that referenced this pull request May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants