Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Enum.HasFlag throwing ArgumentException #1882

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

SandorDobos
Copy link
Contributor

Description

Motivation and Context

How Has This Been Tested?

Using test below.

[Flags]
public enum PinEventTypes
{
    None = 0,
    Rising = 1,
    Falling = 2
}

[TestMethod]
public void MyTestMethod()
{
    PinEventTypes e = PinEventTypes.Falling;
    Assert.False(e.HasFlag(PinEventTypes.Rising));
    Assert.True(e.HasFlag(PinEventTypes.Falling));
}

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@SandorDobos
Copy link
Contributor Author

I confirm that this fix solves nanoframework/Home#725 too.

@josesimoes josesimoes merged commit 07f6e9f into nanoframework:develop Apr 12, 2021
@josesimoes josesimoes changed the title Fixes issue #730 (Enum.HasFlag throws ArgumentException) Fixes Enum.HasFlag throwing ArgumentException Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enum.HasFlag throws ArgumentException
3 participants