Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issue with ToString and numeric value #1853

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Fixes issue with ToString and numeric value #1853

merged 1 commit into from
Mar 9, 2021

Conversation

SandorDobos
Copy link
Contributor

@SandorDobos SandorDobos commented Mar 9, 2021 •
edited by josesimoes
Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: bug label Mar 9, 2021
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Mar 9, 2021
josesimoes
josesimoes approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title Fixing issue #714 ((-3210).ToString("d1") != "-3210") Fixes issue with ToString and numeric value Mar 9, 2021
@josesimoes josesimoes merged commit cda8f69 into nanoframework:develop Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SandorDobos @josesimoes @nfbot