Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace default radom implementation for WIN32 #1849

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Replace standard implementation with Win32 one using a true random generator.

Motivation and Context

  • Improves random API in WIN32 CLR.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added the Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds label Mar 4, 2021
@nfbot
Copy link
Member

nfbot commented Mar 4, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#69.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@josesimoes josesimoes merged commit fb8ff0e into nanoframework:develop Mar 4, 2021
@josesimoes josesimoes deleted the fix-random branch March 4, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Virtual Device & WIN32 Everything related specifically with WIN32 and .NET tool builds Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants