Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes wrong number or read/written bytes for System.Device.I2c #1819

Merged
merged 6 commits into from
Dec 29, 2020
Merged

Fixes wrong number or read/written bytes for System.Device.I2c #1819

merged 6 commits into from
Dec 29, 2020

Conversation

RolandoMagico
Copy link
Contributor

@RolandoMagico RolandoMagico commented Dec 29, 2020

Description

  • Add code to take into account the start and length of SpanByte for read/written operations.

Motivation and Context

How Has This Been Tested?

Not yet tested

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixed dead link
@dnfadmin
Copy link

dnfadmin commented Dec 29, 2020

CLA assistant check
All CLA requirements met.

@nfbot
Copy link
Member

nfbot commented Dec 29, 2020

@RolandoMagico I've fixed the checklist for you.
FYI, the correct format is [x], no spaces inside brackets.

@nfbot nfbot added the Type: dependencies Pull requests that update a dependency file(s) or version label Dec 29, 2020
@josesimoes
Copy link
Member

Hey @RolandoMagico !

First of all: thank you for looking into this. 👍🏻

Please use separate PRs to address each issue: one for the wrong link and another for fixing the SpanByte issue with I2C.

@josesimoes josesimoes removed the Type: dependencies Pull requests that update a dependency file(s) or version label Dec 29, 2020
@josesimoes
Copy link
Member

@RolandoMagico it would be awesome if you could replicate the fix to the STM32 implementation... 😉

@RolandoMagico RolandoMagico changed the title Fixed dead link in README.md Fixes wrong number or read/written bytes for ESP32 System.Device.I2c Dec 29, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 29, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 29, 2020
@RolandoMagico RolandoMagico changed the title Fixes wrong number or read/written bytes for ESP32 System.Device.I2c Fixes wrong number or read/written bytes for System.Device.I2c Dec 29, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 29, 2020
@josesimoes
Copy link
Member

Ignoring build failure for ChibiOS based targets.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit 9a7824e into nanoframework:develop Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Device.I2c.I2cDevice.Write transmits more bytes than expected
4 participants