Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Monitor_TargetInfo command #1789

Merged
merged 1 commit into from
Nov 23, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add new command Monitor_TargetInfo.
  • This command provides detailed target information with booter version, CLR version and other details.
  • Move it to WireProtocol with weak implementation.
  • Remove declaration of helper function Target_GetReleaseInfo.
  • Add Monitor_TargetInfo to debugger class and declarations.

Motivation and Context

  • Add details about target to improve knowledge about target capabilities.

How Has This Been Tested?

  • Debugger test apps.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Nov 23, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#61.

Make sure you are using the project code style. Check the details here.

@josesimoes josesimoes force-pushed the add-target-info branch 3 times, most recently from 8e819f3 to 4081c2c Compare November 23, 2020 12:55
@josesimoes josesimoes force-pushed the add-target-info branch 2 times, most recently from fb2436a to 03615bf Compare November 23, 2020 13:29
- Add new command Monitor_TargetInfo.
- This command provides detailed target information with booter version, CLR version and other details.
- Move it to WireProtocol with weak implementation.
- Remove declaration of helper function Target_GetReleaseInfo.
- Add Monitor_TargetInfo to debugger class and declarations.
- Increase block size of nanobooter for MBN_QUAIL.
@josesimoes josesimoes merged commit c76782b into nanoframework:develop Nov 23, 2020
@josesimoes josesimoes deleted the add-target-info branch November 23, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants