Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Flush fix plus extra SPI displays #1788

Merged
merged 9 commits into from
Nov 23, 2020

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Nov 23, 2020

Description

Changes to the BitBlt method to enable it to work with a window in the bitmap.
Tidied up some code.

Also added initial drivers for SPI displays SSD1331(colour) and SSD1306(mono)
These displays only require a small frame buffer so they can work on an ESP32 without spiram. The SSD1306 also comes in I2C version but held back I2C driver as that requires other changes to share bus and have a generic I2C interface for all platforms.

Motivation and Context

How Has This Been Tested?

Tested using small test program that displayed partial parts of complete screen and also tested with Tetris sample for larger screens( to be updated)

Following combinations tested

  • STM32F769I_DISCOVERY with built in display
  • ESP32 Wrover V4 with ILI9341 display
  • ESP32 Wrover V3 with ST7789V display
  • ESP32 devkit with SSD1331 94x64 colour
  • ESP32 devkit with SPI SSD1306 128x64 mono

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Nov 23, 2020

Hi @AdrianSoundy,

nI'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot
Copy link
Member

nfbot commented Nov 23, 2020

Hi @AdrianSoundy,

😞 You have to make up your mind on how this PR addresses the issue. It either fixes, closes or resolves it. Can't have them all...

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Nov 23, 2020

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/AdrianSoundy/nf-interpreter/pull/16.

Make sure you are using the project code style. Check the details here.

@nfbot
Copy link
Member

nfbot commented Nov 23, 2020

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/AdrianSoundy/nf-interpreter/pull/17.

Make sure you are using the project code style. Check the details here.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the rest LGTM!

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AdrianSoundy AdrianSoundy merged commit 3a2d2c5 into nanoframework:develop Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graphics display corrupted when using partial flush
3 participants