Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work configuration block storage #1748

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add ConfigurationManager_CheckExistingConfigurationBlock to check existing config block (as stub and default implementation).
  • Rework ConfigurationManager for ChibiOS to allow storing Certificate bundle blocks.
  • Improve code to check existing config blocks and prevent
  • Fix storage of certificate bundle.

Motivation and Context

  • Prevents re-writing with the same data.
  • Need to allow storing a CA bundle from managed app (required for server certificates).

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Add ConfigurationManager_CheckExistingConfigurationBlock to check existing config block (as stub and default implementation).
- Rework ConfigurationManager for ChibiOS to allow storing Certificate bundle blocks.
- Improve code to check existing config blocks and prevent re-write with the same data.
- Fix storage of certificate bundle.
@nfbot
Copy link
Member

nfbot commented Oct 26, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Platform: STM32 Everything related specifically with ChibiOS platform hacktoberfest-accepted labels Oct 26, 2020
@josesimoes josesimoes merged commit d0719c4 into nanoframework:develop Oct 26, 2020
@josesimoes josesimoes deleted the work-config-block-storage branch October 26, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Platform: STM32 Everything related specifically with ChibiOS platform Type: bug Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants