Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HAL Initialize/Uninitialize #1677

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jul 8, 2020

Description

  • Add code to stop and release buses and drivers during nanoHAL_Uninitialize.
  • Add code to init control structs of several drivers during nanoHAL_Initialize.
  • Change declarations of control structs of several drivers to use typedef instead of plain structs.
  • Add HAL options to TI SimpleLink to expose I2C and SPI inclusion to be able to properly manage the code in nanoHAL Init/Uninit.

Motivation and Context

How Has This Been Tested?

  • I2C and SPI samples with STM32F429, STM32F091.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Jul 8, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot nfbot added the Type: bug label Jul 8, 2020
@josesimoes josesimoes added Platform: NXP Everything related specifically with FreeRTOS Series: STM32xx Everything related specifically with STM32 targets Series: TI-CC32xx Platform: TI-SimpleLink labels Jul 8, 2020
@nfbot
Copy link
Member

nfbot commented Jul 8, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#15.

Make sure you are using the project code style. Check the details here.

- Add code to stop and release buses and drivers during nanoHAL_Uninitialize.
- Add code to init control structs of several drivers during nanoHAL_Initialize.
- Change declarations of control structs of several drivers to use typedef instead of plain structs.
- Add HAL options to TI SimpleLink to expose I2C and SPI inclusion.
@nfbot
Copy link
Member

nfbot commented Jul 8, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#16.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@josesimoes josesimoes merged commit 3d599d0 into nanoframework:develop Jul 8, 2020
@josesimoes josesimoes deleted the improve-hal-init-deinit branch July 8, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: NXP Everything related specifically with FreeRTOS Platform: TI-SimpleLink Series: STM32xx Everything related specifically with STM32 targets Series: TI-CC32xx Type: bug
Projects
None yet
2 participants