Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SPI4 on STM32F429I-DISCOVERY #1634

Merged
merged 2 commits into from
May 18, 2020
Merged

Support for SPI4 on STM32F429I-DISCOVERY #1634

merged 2 commits into from
May 18, 2020

Conversation

piwi1263
Copy link
Member

Description

  • Activate SPI4 in mcuconf.h
  • Specify the pins in the board's SPI configuration

Motivation and Context

  • Add an SPI to be used for additional hardware, like sensors.

How Has This Been Tested?

Tested with external SPI connected slave. Driver used to be able to test provided by @networkfusion to be found here https://github.com/networkfusion/nanoFramework-Drivers/tree/master/drivers/MAX31865

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 [email protected]

- Add SPI4 to the MCU as well as the SPI configuration

Signed-off-by: piwi1263 <[email protected]>
@nfbot
Copy link
Member

nfbot commented May 15, 2020

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@networkfusion
Copy link
Member

@piwi1263 Is that sharing the same bus between the display and the sensor using different CS pins? It would be a good test if not (presuming the display is SPI?) otherwise LGTM!

@piwi1263
Copy link
Member Author

piwi1263 commented May 16, 2020

@networkfusion No, it is using a different SPI. SPI4 to be more specific, the goal of this was having another SPI avail for external stuff, independent of the display. The display uses SPI5 already sharing the bus with other on board hardware. IIRC the L3GD20 Gyroscope.

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: enhancement labels May 18, 2020
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit 7fa7f45 into nanoframework:develop May 18, 2020
@piwi1263 piwi1263 deleted the F429-add-spi4 branch June 4, 2020 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants