Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing configuration for CS in SPI configuration #1632

Merged
merged 6 commits into from
May 14, 2020
Merged

Add missing configuration for CS in SPI configuration #1632

merged 6 commits into from
May 14, 2020

Conversation

networkfusion
Copy link
Member

Description

The current configuration for the STM32F769I does not work (although it should).
On all targets, it ensures that the CS pin is correctly setup.

How Has This Been Tested?

Tested with the MAX31865 driver on the STM32F769I-DISCO board.

Screenshots

image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@networkfusion
Add working SPI configuration
65424bb
@networkfusion
Merge branch 'develop' of https://github.com/nanoframework/nf-interpr…
09f754a 
…eter into develop-f769i-spi
@networkfusion
Adds setting correct port config for CSPin
b5cc56e 
without using board.h (since the pins could be used for another function
Reverts board.h customizations
@nfbot
Copy link
Member

nfbot commented May 13, 2020

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Fix CS pin configuration
ee10e3e 
- Tweak call to palSetPad.
- Make sure the CS pin is set to high as default.
@josesimoes
Revert typo fix
53dd555
josesimoes
josesimoes approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made some improvements that I think are important.
Care to check on your test rig?

...SIS-OS/ChibiOS/nanoCLR/Windows.Devices.Pwm/win_dev_pwm_native_Windows_Devices_Pwm_PwmPin.cpp Outdated Show resolved Hide resolved
@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug Type: enhancement labels May 14, 2020
@networkfusion
Copy link
Member Author

LGTM

@josesimoes josesimoes changed the title Adds working STM32F769I SPI configuration Add missing configuration for CS in SPI configuration May 14, 2020
@josesimoes josesimoes merged commit 3b5919d into nanoframework:develop May 14, 2020
@josesimoes
Copy link
Member

pinging @KiwiBryn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@networkfusion @nfbot @josesimoes