Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRC32 calculation for CC32xx SDK #1627

Merged
merged 1 commit into from
May 5, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Internal code doesn't handle properly calls with 0 size. Add check for these situations.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

- Internal code doesn't handle properly calls with 0 size. Add check for these situations.

Signed-off-by: josesimoes <[email protected]>
@nfbot
Copy link
Member

nfbot commented May 5, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 5a66cb8 into nanoframework:develop May 5, 2020
@josesimoes josesimoes deleted the fix-crc32-cc32xx branch May 5, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuring wifi settings on TI CC3220 will freeze Visual Studio Deploying failed for TI CC3220SF
2 participants