Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on boot and debugger #1624

Merged
merged 1 commit into from
May 5, 2020
Merged

Work on boot and debugger #1624

merged 1 commit into from
May 5, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented May 5, 2020 •
edited
Loading

Description

  • Add Debugger_Discovery to debugger.
  • Add call to Debugger_Discovery in CLRStartup.
  • Add Ping_Source_Host to Monitor_Ping_Source_Flags enum.
  • Remove wrong debug messages from startup.
  • Improve debug messages on startup.
  • Bring Win32 CLRStartup in sync with native one.

⚠️ REQUIRES VS EXTENSION > 2019.2.0/2017.2.0 ⚠️

Motivation and Context

  • Improves boot:
    • boot sequence on VS debug session start.
    • messages output to VS output console.

How Has This Been Tested?

  • VS experimental instance running debug v1.16.0-preview.15.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

@josesimoes
Work on boot and debugger
e4beec2 
- Add Debugger_Discovery to debugger.
- Add call to Debugger_Discovery in CLRStartup.
- Add Ping_Source_Host to Monitor_Ping_Source_Flags enum.
- Remove wrong debug messages from startup.
- Improve debug messages on startup.
- Bring Win32 CLRStartup in sync with native one.

Signed-off-by: josesimoes <[email protected]>
@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries Breaking-change labels May 5, 2020
@nfbot
Copy link
Member

nfbot commented May 5, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes mentioned this pull request May 5, 2020
Merged
8 tasks
@josesimoes josesimoes merged commit b3b28b6 into nanoframework:develop May 5, 2020
@josesimoes josesimoes deleted the boot-debug-improvements branch May 5, 2020 15:30
@josesimoes josesimoes mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Breaking-change Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot