Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix access to DateTime fields in Windows.Storage #1595

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

morali
Copy link
Contributor

@morali morali commented Mar 26, 2020

You cannot use directly datetime fields anymore, so Windows.Storage needed changed to apply correct date to files.

Description

After updating nF extension to latest version, setting datetime fields didn't work anymore. Accessing date created filed in VS caused instant hardfault. I changed the code to fix this problem.

Motivation and Context

How Has This Been Tested?

Tested with sample files from nF.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: morali[email protected]

@nfbot
Copy link
Member

nfbot commented Mar 26, 2020

Hi @morali,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: NXP i6 Everything related specifically with NXP targets Type: bug labels Mar 30, 2020
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(I haven't tested on real hardware)

@josesimoes josesimoes changed the title Updated Windows.Storage in NXP port to work with new version of vs extension Fix access to DateTime fields in Windows.Storage Mar 30, 2020
@josesimoes josesimoes merged commit 176d116 into nanoframework:develop Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: NXP i6 Everything related specifically with NXP targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants