Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for microSD Click board. #1591

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Support for microSD Click board. #1591

merged 1 commit into from
Mar 25, 2020

Conversation

piwi1263
Copy link
Member

Description

Fixed support for microSD Click board on socket one! Additional comments were added when another click board socket needs to be utalized. Only removal events where detected in C#. Issue #586 has been initiated to address this.

Motivation and Context

Events for the SD Card where not detected while inserting/removing.

How Has This Been Tested?

Using the Storage/RemovableDeviceEvent sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 [email protected]

Fixed support for microSD Click board on socket one!

Signed-off-by: piwi1263 <[email protected]>
@nfbot
Copy link
Member

nfbot commented Mar 22, 2020

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: enhancement labels Mar 25, 2020
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks.

@josesimoes josesimoes merged commit 217558d into nanoframework:develop Mar 25, 2020
@piwi1263 piwi1263 deleted the quail_sd_fix branch March 26, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants