Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reboot on idle #1583

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Add call to watchdog reset on Events_WaitForEvents loop.
    (for all platforms even if they don't explicitly implement watchdog to make it clear on future changes)

Motivation and Context

  • After the fix with Fix time conversion issues in PAL events #1566 STM32 targets where rebooting on idle. The reason was the watchdog kicking in as the wait now happens inside the Events_WaitForEvents loop, which didn't happen before.

How Has This Been Tested?

  • Tested with simple loop and infinite timeout on main().

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

- After the fix with nanoframework#1566 STM32 targets where rebooting on idle. The reason was the watchdog kicking in as the wait now happens inside the Events_WaitForEvents loop.

Signed-off-by: josesimoes <[email protected]>
@nfbot
Copy link
Member

nfbot commented Mar 10, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 9c7c57c into nanoframework:develop Mar 10, 2020
@josesimoes josesimoes deleted the fix-reboot-on-idle branch March 10, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants