Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work SWO handlers #1579

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Work SWO handlers #1579

merged 1 commit into from
Mar 5, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Remove asserts.
  • Remove static inline attribute.

Motivation and Context

  • No need for assert statements anymore.
  • Remove inline attribute as it doesn't make much sense trying to force this. Better leave it to the linker to decide.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Remove asserts.
- Remove static inline attribute.
@josesimoes josesimoes added Type: enhancement Series: STM32xx Everything related specifically with STM32 targets labels Mar 5, 2020
@nfbot
Copy link
Member

nfbot commented Mar 5, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit db9c666 into develop Mar 5, 2020
@josesimoes josesimoes deleted the josesimoes-patch-2 branch March 5, 2020 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants