Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified timeout handling on flash driver v2 #1577

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Mar 5, 2020

Description

  • Replace loop with calls to ChibiOS time with simple while loop.

Motivation and Context

  • No point wasting calls to ChibiOS time. If the flash operation really goes south there is nothing to do and the watchdog will kick.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes [email protected]

- No point wasting calls to ChibiOS time. If the flash operation really goes south there is nothing to do and the watchdog will kick.
@nfbot
Copy link
Member

nfbot commented Mar 5, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: enhancement labels Mar 5, 2020
@josesimoes josesimoes merged commit 14b5826 into develop Mar 5, 2020
@josesimoes josesimoes deleted the josesimoes-patch-2 branch March 5, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants