Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong get socket error method #1572

Merged
merged 1 commit into from
Mar 5, 2020

Conversation

martin-kuhn
Copy link
Contributor

Description

During network tests we found out, that using SOCK_getlasterror() instead of SOCK_getsocklasterror() leads to an infinite loop when a remote client closes the network socket unexpectedly. Hence the watchdog will not be fed anymore and it will trigger a reset.

How Has This Been Tested?

This has been tested on a custom STM32F427 based MCU board with network capabilities.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Martin Kuhn [email protected]

@nfbot
Copy link
Member

nfbot commented Mar 5, 2020

Hi @martin-kuhn,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: bug labels Mar 5, 2020
@josesimoes josesimoes merged commit 1a07cb5 into nanoframework:develop Mar 5, 2020
@josesimoes josesimoes changed the title [network] fix wrong get socket error method Fix wrong get socket error method Mar 5, 2020
@martin-kuhn martin-kuhn deleted the lwip branch March 5, 2020 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants