Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with wrong context switching and global lock calls #1567

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

martin-kuhn
Copy link
Contributor

Description

Enabling the debug checks showed, that some functions are called in the wrong context. We have to use methods with the correct postfix depending whether in ISR context or not. There are also functions which can be called from both contexts so we have to handle that.
We also have to make sure that GLOBAL_LOCK uses the correct SysLock depending whether in ISR or not.

How Has This Been Tested?

This has been tested on a custom STM32F427 based MCU board.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Martin Kuhn [email protected]

@nfbot
Copy link
Member

nfbot commented Feb 26, 2020

Hi @martin-kuhn,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Platform: STM32 Everything related specifically with ChibiOS platform Status: under review Type: bug labels Feb 26, 2020
@josesimoes
Copy link
Member

@AdrianSoundy could please review these changes? As this is touch sensitive areas, better have another pair of eyes looking into this.

Also please check if this calls for any changes in ESP32 to mirror the ones made in ChibiOS.

@josesimoes
Copy link
Member

@martin-kuhn could you please merge the latest from upstream develop?

@martin-kuhn
Copy link
Contributor Author

Yes of course, it's done.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title fix wrong context issues Fix issues with wrong context switching and global lock calls Mar 3, 2020
@josesimoes josesimoes added Area: Common libs Everything related with common libraries and removed Status: under review labels Mar 3, 2020
@josesimoes josesimoes merged commit 31f9aa8 into nanoframework:develop Mar 3, 2020
@martin-kuhn martin-kuhn deleted the context branch March 5, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Platform: STM32 Everything related specifically with ChibiOS platform Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants