Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type correction in Interop (unsigned as signed) #1531

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

NiciAndres
Copy link
Contributor

Description

The parameter list of the functions Interop_Marshal_UINT16() and Interop_Marshal_UINT32() were not consistent with the header file.

Motivation and Context

The use of the Interop function Interop_Marshal_UINT16(…), which is defined in nanoCLR_Interop.h, caused a undefined reference error. One parameter type was specified as unsigned short/int in the headerfile, whereas in the sourcefile it was specified as signed short/int. I changed it to unsigned in the sourcefile, which is obviously the desired one.

How Has This Been Tested?

This function has been tested with the use of an own Interop Library.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: NiciAndres [email protected]

@nfbot
Copy link
Member

nfbot commented Dec 17, 2019

Hi @NiciAndres,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@claassistantio
Copy link

claassistantio commented Dec 17, 2019

CLA assistant check
All committers have signed the CLA.

@josesimoes josesimoes changed the title Typo Correction Interop (unsiged as signed) Type correction in Interop (unsigned as signed) Dec 18, 2019
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! thanks 💯

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Type: bug labels Dec 18, 2019
@josesimoes josesimoes merged commit 77f0748 into nanoframework:develop Dec 18, 2019
@NiciAndres NiciAndres deleted the TypFix-Interop branch December 19, 2019 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants