Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeRTOS: Rework GLOBAL_LOCK() and GLOBAL_UNLOCK() #1518

Merged
merged 1 commit into from
Nov 27, 2019
Merged

FreeRTOS: Rework GLOBAL_LOCK() and GLOBAL_UNLOCK() #1518

merged 1 commit into from
Nov 27, 2019

Conversation

MateuszKlatecki
Copy link
Member

Description

Rework GLOBAL_LOCK () and GLOBAL_UNLOCK () so that you can enter the critical section in the interrupt.
This is necessary to be able to call PostManagedEvent in the interrupt

Motivation and Context

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Mateusz Klatecki [email protected]

@nfbot
Copy link
Member

nfbot commented Nov 27, 2019

Hi @MateuszKlatecki,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@MateuszKlatecki MateuszKlatecki changed the title FreeRTOS: Rework GLOBAL_LOCK() and GLOBAL_UNLOCK FreeRTOS: Rework GLOBAL_LOCK() and GLOBAL_UNLOCK() Nov 27, 2019
josesimoes
josesimoes approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added Platform: NXP Everything related specifically with FreeRTOS Type: enhancement labels Nov 27, 2019
@josesimoes josesimoes merged commit 5c4d88c into nanoframework:develop Nov 27, 2019
@AdrianSoundy AdrianSoundy mentioned this pull request Nov 27, 2019
Merged
10 tasks
@MateuszKlatecki MateuszKlatecki deleted the global_locks branch June 22, 2020 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Platform: NXP Everything related specifically with FreeRTOS Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MateuszKlatecki @nfbot @josesimoes