Fix endless loop in 1-Wire during ID search

[up-streamer]

Description

• Correct the comparison at the end of FindNext() to terminate de search.
• This fix applies for ESP32 and STM32
• The comparison was not was done in correct way, as per Maxim APP note AN187.
  from: if (romBitIndex < (65 || lastcrc8)
  goes to: if ((romBitIndex < 65) || (lastcrc8 != 0))

Motivation and Context

• This is required in order to make OneWire drive be able to address more than two devices on the bus.
• Not hanging the application until it reaches out of memory.
• Fixes OneWire going into endless loop when seaching devices Home#541.

How Has This Been Tested?

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

Signed-off-by: up-streamer [email protected]

[nfbot]

Hi @up-streamer,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

[CLAassistant]

All committers have signed the CLA.

[josesimoes]

Much better now!

LGTM. 👏

[up-streamer]

Thanks!
Living and learning.