Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code on enumerating removable and internal storage folders #1437

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Aug 27, 2019

Description

  • These code lines don't need to be here because, when there are no internal/removable folders the correct return object it's an empty collection of StorageFolder (which is happening). These lines must be a left over from initial coding and were wrongly left there.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Aug 27, 2019
@nfbot
Copy link
Member

nfbot commented Aug 27, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets and removed Area: Common libs Everything related with common libraries labels Aug 27, 2019
@josesimoes josesimoes merged commit bf611b8 into nanoframework:develop Aug 27, 2019
@josesimoes josesimoes deleted the fix-513 branch August 27, 2019 09:07
josesimoes added a commit that referenced this pull request Aug 27, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Oct 17, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Oct 18, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Oct 23, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Oct 30, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Nov 5, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Nov 8, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
josesimoes added a commit that referenced this pull request Nov 14, 2019
- Following #1437.

Signed-off-by: José Simões <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception when getting folders for internal and removable drives
2 participants