Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for X509Certificate2 #1412

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Rework several functions to accept private key and password.
  • Add new function to parse private keys.
  • Add and update stubs accordingly.
  • Rework SslNative::InitHelper accordingly.
  • Update CMakes as required.
  • Update declaration or System.Net assembly.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries Breaking-change labels Jul 18, 2019
@nfbot
Copy link
Member

nfbot commented Jul 18, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Rework several functions to accept private key and password.
- Add new function to parse private keys.
- Add and update stubs accordingly.
- Rework SslNative::InitHelper accordingly.
- Update CMakes as required.
- Update declaration or System.Net assembly.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes merged commit de8700f into nanoframework:develop Jul 18, 2019
@josesimoes josesimoes deleted the work-secure-sockets branch July 18, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Breaking-change Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants