Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Base64 conversion #1407

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Fix Base64 conversion #1407

merged 1 commit into from
Jul 12, 2019

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jul 12, 2019 •
edited
Loading

Description

  • Add code to check call result.
  • Fix call to conversion functions by passing the buffer length.
  • Fix typo in var name.

Motivation and Context

How Has This Been Tested?

  • Base64 conversion sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões [email protected]

@josesimoes
Fix Base64 implementation
6ad7389 
- Add code to check call result.
- Fix call to conversion  functions by passing the buffer length.
- Fix typo in var.

Signed-off-by: José Simões <[email protected]>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Jul 12, 2019
@nfbot
Copy link
Member

nfbot commented Jul 12, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Fix Base64 implementation Fix Base64 conversion Jul 12, 2019
@josesimoes josesimoes merged commit 46e41ec into nanoframework:develop Jul 12, 2019
@josesimoes josesimoes deleted the fix-base64 branch July 12, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot